pgsql-hackers
❮
Correction to comment of brin_range_deserialize
- Jump to comment-1ji xu<thanksgreed@gmail.com>Jan 28, 2026, 8:11 AM UTCHi Hackers,
I found an issue in the comments of the
src/backend/access/brin/brinminmaxmulti.c file.
The header comment of function brinrangedeserialize currently reads:
"Serialize the in-memory representation into a compact varlena value."
which looks like a copy/paste error, where "Serialize" should be
"Deserialize".
I'm posting this patch to fix the comment.
Regards,
ji xu- Jump to comment-1Chao Li<li.evan.chao@gmail.com>Jan 28, 2026, 11:14 PM UTC
On Jan 28, 2026, at 16:10, ji xu <thanksgreed@gmail.com> wrote:
Hi Hackers,
I found an issue in the comments of the src/backend/access/brin/brinminmaxmulti.c file.
The header comment of function brinrangedeserialize currently reads:
"Serialize the in-memory representation into a compact varlena value."
which looks like a copy/paste error, where "Serialize" should be "Deserialize".
I'm posting this patch to fix the comment.
Regards,
ji xu<v1-0001-Correction-to-comment-of-brinrangedeserialize.patch>
Indeed, like a copy-pasto from the initial commit (ab59610) where the 2 functions (serialize/deserialize) were added.
The updated comment in the patch looks good to me.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/- Jump to comment-1Michael Paquier<michael@paquier.xyz>Jan 29, 2026, 12:22 AM UTCOn Thu, Jan 29, 2026 at 07:13:44AM +0800, Chao Li wrote:
Indeed, like a copy-pasto from the initial commit (ab59610) where
Clearly a copy-pasto. I've picked up that for later, thanks for the
the 2 functions (serialize/deserialize) were added.
The updated comment in the patch looks good to me.
report.
--
Michael