postgres.email
❮

Remove unused argument from ApplyLogicalMappingFile()

  • Jump to comment-1
    Yugo Nagata<nagata@sraoss.co.jp>
    Jan 28, 2026, 3:01 AM UTC
    Hi,
    I noticed that ApplyLogicalMappingFile() has an unused argument.
    If there is no specific reason for keeping it, I think it could be
    removed. I have attached a small patch that removes this argument.
    Regards,
    Yugo Nagata
    --
    Yugo Nagata <nagata@sraoss.co.jp>
    View in PostgreSQL Archives →
    • Jump to comment-1
      Hayato Kuroda (Fujitsu)<kuroda.hayato@fujitsu.com>
      Jan 28, 2026, 5:18 AM UTC
      Dear Nagata-san,
      I noticed that ApplyLogicalMappingFile() has an unused argument.
      If there is no specific reason for keeping it, I think it could be
      removed. I have attached a small patch that removes this argument.
      Good catch. I found that ApplyLogicalMappingFile() has the argument since it was
      introduced (b89e151) and was not used from the beginning. Maybe it was a
      copy-to-paste mistake from UpdateLogicalMappings()?
      I removed the argument and ran tests for subscription, they could be passed.
      Best regards,
      Hayato Kuroda
      FUJITSU LIMITED
      View in PostgreSQL Archives →
      • Jump to comment-1
        Fujii Masao<masao.fujii@gmail.com>
        Jan 28, 2026, 9:24 AM UTC
        On Wed, Jan 28, 2026 at 2:18 PM Hayato Kuroda (Fujitsu)
        <kuroda.hayato@fujitsu.com> wrote:

        Dear Nagata-san,
        I noticed that ApplyLogicalMappingFile() has an unused argument.
        If there is no specific reason for keeping it, I think it could be
        removed. I have attached a small patch that removes this argument.
        Thanks for the patch! I will commit it.
        Good catch. I found that ApplyLogicalMappingFile() has the argument since it was
        introduced (b89e151) and was not used from the beginning.
        Yes.
        I removed the argument and ran tests for subscription, they could be passed.
        Thanks for the test!
        Regards,
        --
        Fujii Masao
        View in PostgreSQL Archives →
        • Jump to comment-1
          Fujii Masao<masao.fujii@gmail.com>
          Jan 30, 2026, 12:08 AM UTC
          On Wed, Jan 28, 2026 at 6:23 PM Fujii Masao <masao.fujii@gmail.com> wrote:

          On Wed, Jan 28, 2026 at 2:18 PM Hayato Kuroda (Fujitsu)
          <kuroda.hayato@fujitsu.com> wrote:

          Dear Nagata-san,
          I noticed that ApplyLogicalMappingFile() has an unused argument.
          If there is no specific reason for keeping it, I think it could be
          removed. I have attached a small patch that removes this argument.

          Thanks for the patch! I will commit it.
          I've pushed the patch. Thanks!
          Regards,
          --
          Fujii Masao
          View in PostgreSQL Archives →