fasthash32() returning uint64?

  • Jump to comment-1
    Jeff Davis<pgsql@j-davis.com>
    Apr 5, 2024, 8:47 PM UTC
    In hashfn_unstable.h, fasthash32() is declared as:
    /* like fasthash64, but returns a 32-bit hashcode */
    static inline uint64
    fasthash32(const char *k, size_t len, uint64 seed)
    Is the return type of uint64 a typo?
    Regards,
    Jeff Davis
    • Jump to comment-1
      John Naylor<johncnaylorls@gmail.com>
      Apr 6, 2024, 1:08 AM UTC
      On Sat, Apr 6, 2024 at 3:47 AM Jeff Davis <pgsql@j-davis.com> wrote:
      In hashfn_unstable.h, fasthash32() is declared as:

      / like fasthash64, but returns a 32-bit hashcode /
      static inline uint64
      fasthash32(const char *k, size_t len, uint64 seed)

      Is the return type of uint64 a typo?
      Yes it is, will fix, thanks!